Repository navigation
Feat/polyline arrows - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds elbow and curved lines and arrows, and releases them as 1.1.0.
Elbow and curved lines. The style panel has a new Shape option for the line and arrow tools: straight, elbow, or curve.
Data model.
LinearShapegains optionalvia(points the line passes through) andcurved. Lines without them are straight as before, so existing documents are unchanged. Older versions of the library show new elbow and curved lines as straight lines and don't break. New exports: theLineRoutetype, andlineRouteinStyleState.Release on version bump.
release.ymlnow runs on pushes tomain. When the version inpackage.jsonisn't on npm yet, it:nextas the dist-tag for pre-releases;vX.Y.Z;CHANGELOG.mdsection.Merges that keep the version publish nothing. CI fails if
CHANGELOG.mdhas no section for the current version.Formatting. Prettier and
.editorconfignow enforce 2-space indentation. ESLint's formatting rules were removed in favour of Prettier. The reformat is a separate commit, listed in.git-blame-ignore-revs. The built bundle is identical apart from whitespace.Website and docs.
Version. Bumped to 1.1.0.
How was it tested?
pnpm lint && pnpm typecheck && pnpm testpass (66 tests, 14 new for lines;pnpm format:checkpasses too)pnpm dev): drew straight, elbow and curved arrows; switched the shape of selected lines; used dashed style; undo; light and dark mode. Touch not tested.docs/screenshot-*.pngin this PR)